Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support in Wi-Fi and NET samples that was removed #17922

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Re-add support in Wi-Fi and NET samples that was removed #17922

merged 2 commits into from
Oct 25, 2024

Conversation

simensrostad
Copy link
Contributor

@simensrostad simensrostad commented Oct 16, 2024 •
edited
Loading

Re-add board support in Wi-Fi and NET samples that was removed
in the last upmerge.

edit
depends on #18066
depends on #17951

@simensrostad simensrostad requested review from a team as code owners October 16, 2024 10:38
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 16, 2024
@simensrostad simensrostad marked this pull request as draft October 16, 2024 10:38
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 16, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 24

Inputs:

Sources:

sdk-nrf: PR head: e28d0456ef5cbc6e58d16a938245a652368ee617

more details

sdk-nrf:

PR head: e28d0456ef5cbc6e58d16a938245a652368ee617
merge base: d036325af5dd69b75bb27f4ed7c1b01b2375186c
target head (main): d290578a5c17cbbb23578f299c7afc329dc7af25
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (26) 
applications
│  ├── asset_tracker_v2
│  │  │ Kconfig.sysbuild
samples
│  ├── debug
│  │  ├── memfault
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp.conf
│  │  │  ├── prj.conf
│  │  │  │ sample.yaml
│  ├── net
│  │  ├── aws_iot
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  │  ├── azure_iot_hub
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  ├── prj.conf
│  │  │  │ sample.yaml
│  │  ├── coap_client
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  │  ├── download
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  │  ├── http_server
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  │  ├── https_client
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  │  ├── mqtt
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  ├── overlay-tls-nrf70.conf
│  │  │  │ sample.yaml
│  │  ├── udp
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp_ns.conf
│  │  │  │ sample.yaml
│  ├── wifi
│  │  ├── provisioning
│  │  │  ├── softap
│  │  │  │  │ prj.conf
│  │  ├── scan
│  │  │  │ sample.yaml
scripts
│  │ quarantine.yaml

Outputs:

Toolchain

Version: add720b6d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:add720b6d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 225
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-sdk-wifi
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@simensrostad simensrostad force-pushed the suppnetsamplesthingy branch 4 times, most recently from 8a9ce29 to 18c3c8f Compare October 18, 2024 10:10
@simensrostad simensrostad added CI-disable Disable CI for this PR DNM labels Oct 18, 2024
@simensrostad simensrostad force-pushed the suppnetsamplesthingy branch 2 times, most recently from cb88813 to adb4582 Compare October 18, 2024 11:00
@simensrostad simensrostad added this to the 2.8.0 milestone Oct 18, 2024
@simensrostad simensrostad force-pushed the suppnetsamplesthingy branch 3 times, most recently from 9b72e3d to 4171815 Compare October 22, 2024 13:50
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/[email protected] nrfconnect/sdk-nrfxlib#1525 nrfconnect/sdk-nrfxlib#1525/files
zephyr nrfconnect/[email protected] nrfconnect/sdk-zephyr#2142 nrfconnect/sdk-zephyr#2142/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@simensrostad simensrostad force-pushed the suppnetsamplesthingy branch 2 times, most recently from 14f9598 to 87c01ea Compare October 22, 2024 19:14
@simensrostad
Copy link
Contributor Author

L2 backend disabled in #17951 in order to build
@glarsennordic

Will reinstate the change in this PR once that is in.

@simensrostad simensrostad added the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Oct 25, 2024
@simensrostad simensrostad requested a review from a team as a code owner October 25, 2024 10:15
@simensrostad simensrostad changed the title Re-add board support in Wi-Fi and NET samples that was removed Re-add support in Wi-Fi and NET samples that was removed Oct 25, 2024
@simensrostad simensrostad force-pushed the suppnetsamplesthingy branch 2 times, most recently from 6f03adb to ac1f471 Compare October 25, 2024 12:39
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed doc-required PR must not be merged without tech writer approval. manifest labels Oct 25, 2024
@simensrostad simensrostad removed DNM manifest-zephyr manifest-nrfxlib changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 25, 2024
@simensrostad simensrostad assigned rlubos and unassigned shanthanordic Oct 25, 2024
bjda
bjda approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@bjda bjda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 25, 2024
krish2718
krish2718 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simensrostad FYI https://github.com/nrfconnect/sdk-nrf/pull/18120/files#r1816742461 I have tested MQTT and it does need an update, but I thought I will let you do this in this PR context, FYI #18227

@simensrostad
samples: Re-add support for nRF7002 and Thingy91x targets
ec56645 
Re-add support for nRF7002 and Thingy91x targets

Signed-off-by: Simen S. Røstad <[email protected]>
@simensrostad
quarantine: Remove Thingy:91 and ATv2
e28d045 
Remove Thingy:91 and ATv2 from the quarantine list.

Signed-off-by: Simen S. Røstad <[email protected]>
@simensrostad simensrostad removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 25, 2024
@rlubos rlubos merged commit 5af5938 into nrfconnect:main Oct 25, 2024
14 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish2718 krish2718 krish2718 left review comments

@bjda bjda bjda approved these changes

@jhn-nordic jhn-nordic jhn-nordic approved these changes

@rlubos rlubos rlubos approved these changes

@jtguggedal jtguggedal jtguggedal approved these changes

@D-Triveni D-Triveni Awaiting requested review from D-Triveni D-Triveni is a code owner

@muraliThokala muraliThokala Awaiting requested review from muraliThokala

@bama-nordic bama-nordic Awaiting requested review from bama-nordic bama-nordic is a code owner

@sachinthegreen sachinthegreen Awaiting requested review from sachinthegreen

@rado17 rado17 Awaiting requested review from rado17

@wentong-li wentong-li Awaiting requested review from wentong-li

@coderbyheart coderbyheart Awaiting requested review from coderbyheart

Assignees

@rlubos rlubos

Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch bugfix Fixes a known bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
8 participants
@simensrostad @NordicBuilder @jtguggedal @rlubos @jhn-nordic @bjda @krish2718 @shanthanordic